Add workaround for iOS build #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@karroffel I've mistakenly pushed the |
ghost
mentioned this pull request
Closed
There is an issue in bindgen that prevents building for the aarch64-apple-ios target. This works arounds the issue by replacing aarch64 with arm64 which clang can understand. Also fixes conditional includes for macOS, which was using the target of the *build script* instead of the target we're building for. Close #285
simlay
reviewed
May 21, 2020
| "MacOSX" | ||
| } else if cfg!(target_os = "ios") { | ||
| } else if target_os == "ios" { |
There was a problem hiding this comment.
I'm late to the party but have been messing around with rust on iOS for a bit lately and in order to better handle #343, I think you'll want to do something like my WIP uikit-sys crate. I think it's a bit more idiomatic to use xcrun to get the include path.
There was a problem hiding this comment.
Thanks for the suggestion! I have created a separate issue for this improvement: #352. A PR would be great if you'd like to create one!
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in bindgen that prevents building for the
aarch64-apple-iostarget. This works arounds the issue by replacingaarch64witharm64which clang can understand.Also fixes conditional includes for macOS, which was using the target of the build script instead of the target we're building for.
Close #285