Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test + workaround: Eq/Ord for StringName #912

Merged
merged 2 commits into from
Jul 17, 2022
Merged

Test + workaround: Eq/Ord for StringName #912

merged 2 commits into from
Jul 17, 2022

Conversation

Bromeon
Copy link
Member

@Bromeon Bromeon commented Jul 17, 2022

Upstream bug, see godotengine/godot#63104

This adds tests for StringName's equality and ordering relation.

@Bromeon Bromeon added bug c: core Component: core (mod core_types, object, log, init, ...) status: upstream Issue that originates in an upstream project and can't be dealt with here. labels Jul 17, 2022
@Bromeon Bromeon added this to the v0.10.1 milestone Jul 17, 2022
@Bromeon Bromeon mentioned this pull request Jul 17, 2022
Merged
@Bromeon
Copy link
Member Author

Bromeon commented Jul 17, 2022

bors r+

@Bromeon Bromeon marked this pull request as ready for review July 17, 2022 15:41
@bors
Copy link
Contributor

bors bot commented Jul 17, 2022

Build succeeded:

@bors bors bot merged commit 2560d1d into godot-rust:master Jul 17, 2022
@Bromeon Bromeon deleted the bugfix/string-name-eq-ord branch July 17, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug c: core Component: core (mod core_types, object, log, init, ...) status: upstream Issue that originates in an upstream project and can't be dealt with here.
Projects
None yet
Milestone
v0.10.1
Development

Successfully merging this pull request may close these issues.
1 participant
@Bromeon