Make ptrcalls opt-in #973
Merged
Make ptrcalls opt-in #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
feature
|
bors try |
tryBuild succeeded: |
chitoyuu
force-pushed
the
feature/opt-in-ptrcall
branch
from
0311a18
to
c1402bf
Compare
|
CI was broken: bors try |
tryBuild succeeded: |
This implements cuddlefishie's suggestion in godot-rust#814, but with the semantics reversed to better conform with Cargo's additive combination of features. - Added the new feature flag `ptrcall`, which enables performant API calls at the cost of forward binary compatibility with the engine. - Added tests with and without the feature to the full CI suite.
chitoyuu
force-pushed
the
feature/opt-in-ptrcall
branch
from
cd3e140
to
416e24d
Compare
|
CI fixed. Marking as ready-for-review. |
|
Merging this for now. bors r+ |
|
Build succeeded: |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements cuddlefishie's suggestion in #814, but with the semantics reversed to better conform with Cargo's additive combination of features.
ptrcall, which enables performant API calls at the cost of forward binary compatibility with the engine.I believe the current semantics to be better, since by making the safer option the default, it helps reduce the surprise factor when someone tries to use the crate with a supposedly compatible version of Godot. Different opinions are welcome.
Note that this only addresses binary compatibility -- #814 is also in a large part an API problem.