Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CharString implementation doesn't match Godot's #1142

Closed
dsnopek opened this issue Jun 15, 2023 · 0 comments · Fixed by #1150
Closed

CharString implementation doesn't match Godot's #1142

dsnopek opened this issue Jun 15, 2023 · 0 comments · Fixed by #1150
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation

Comments

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 15, 2023

Godot version

v4.1.beta.custom_build.19c1d3c7a

godot-cpp version

4.1.dev (1bc9ca7)

System information

Linux

Issue description

The CharString implementation in godot-cpp is much simpler, and not compatible with what's in Godot. This makes it harder to have a module that can also be compiled as a GDExtension.

This was discovered when trying to compile the text_server_adv module in Godot as a GDExtension.

See: godotengine/godot#77532

Steps to reproduce

# Assuming you have Godot's source code in 'godot'
cd godot/modules/text_server_adv/gdextension_build
scons

Minimal reproduction project

n/a

@dsnopek dsnopek added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant