Attempt to fully implement CharString #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
the
enhancement
dsnopek
force-pushed
the
charstring-full
branch
3 times, most recently
from
403485c
to
8ad640a
Compare
dsnopek
changed the title
|
This is now working in my very limited testing, so I'm taking it out of draft to try and get some review :-) |
bruvzg
approved these changes
Jul 7, 2023
|
Discussed at GDExtension meeting, and this looks fine! |
vnen
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142
This copies
CharString(along withCharProxy) from Godot, and then uses a templateCharStringT<T>to avoid having to duplicate code forCharString,Char16String,Char32StringandCharWideString(which are all essentially the same, just using a different character size).It seems to be working, but I did only very limited testing, including adding a simple automated test that just calls
String.utf8()and ensures it matches the expected value.It could definitely use more testing!