Check that GDExtension is opened by compatible Godot version #1208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #1193 and adds something that we discussed on issue #1195:
That is, godot-cpp will compare the version of Godot it was built for (based on the
extension_api.json
that was used) with the version of Godot that is loading it, and ensure that they are compatible, ie. the version of Godot is equal to or greater than the version godot-cpp was built for.In order to do this, it also:
extension_api.json
in the repo for Godot 4.2-dev3, since we still had the one from 4.1.1 in there.String
, because we made some small incompatible changes toString
in 4.2. This highlights the need to abort early if an older Godot tries to load a newer GDExtension!