Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Add silence_msvc option for Windows #1507

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jun 25, 2024

Brings over the silence_msvc option from the main repo, which suppresses all redundant output from MSVC's cl/link tools. Additionally, any error output that does occur is instead rerouted to stderr as expected, instead of printing it in stdout for some reason.

Before:

Compiling D:\Godot\Github\godot-cpp\gen\src\classes\popup.cpp ...
animation_node_blend3.cpp
visual_shader_node_varying.cpp
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\visual_shader_node_uv_func.cpp ...
shape_cast2d.cpp
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\gpu_particles_collision_sdf3d.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\gltf_camera.cpp ...
v_split_container.cpp
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\script_create_dialog.cpp ...
progress_bar.cpp
char_fx_transform.cpp
gltf_state.cpp
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\v_box_container.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\popup_menu.cpp ...
shape2d.cpp
popup.cpp

After:

Compiling D:\Godot\Github\godot-cpp\gen\src\classes\grid_container.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\visual_shader_node_curve_xyz_texture.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\open_xr_composition_layer_quad.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\skin_reference.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\graph_frame.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\render_scene_buffers_configuration.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\visual_shader_node_float_op.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\navigation_mesh_generator.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\gradient.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\noise_texture3d.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\web_socket_multiplayer_peer.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\visual_shader_node_linear_scene_depth.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\mutex.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\gpu_particles_collision_sphere3d.cpp ...
Compiling D:\Godot\Github\godot-cpp\gen\src\classes\render_scene_buffers.cpp ...

@Repiteo Repiteo added enhancement This is an enhancement on the current functionality platform:windows topic:buildsystem Related to the buildsystem or CI setup labels Jun 25, 2024
@Repiteo Repiteo added this to the 4.x milestone Jun 25, 2024
@Repiteo Repiteo requested a review from a team as a code owner June 25, 2024 14:33
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works great in my testing :-)

I compared the code with what's in Godot, and there's only minor changes that all make sense in this context.

@dsnopek dsnopek merged commit 53b546e into godotengine:master Jun 25, 2024
12 checks passed
@Repiteo Repiteo deleted the silence-msvc branch June 25, 2024 22:55
@dsnopek
Copy link
Collaborator

dsnopek commented Jul 17, 2024

Cherry-picked for 4.2 in PR #1527

@dsnopek
Copy link
Collaborator

dsnopek commented Jul 17, 2024

Cherry-picked for 4.1 in PR #1529

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality platform:windows topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants