Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change PropertyInfo members to String. #826

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Change PropertyInfo members to String. #826

merged 1 commit into from
Sep 15, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 2, 2022

Improves ability to dynamically define properties, without handling char * allocation / de-allocation manually.

@bruvzg bruvzg added enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Sep 2, 2022
@bruvzg bruvzg added this to the 4.0 milestone Sep 2, 2022
@bruvzg bruvzg changed the title [WIP] Change PropertyInfo members to String. Change PropertyInfo members to String. Sep 14, 2022
@bruvzg bruvzg marked this pull request as ready for review September 14, 2022 05:41
@akien-mga akien-mga merged commit f24cc8b into godotengine:master Sep 15, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the string_info branch September 15, 2022 19:10
This was referenced Sep 18, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga