2D : Simple mouse drawing demo #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works great for me. 👍
|
pwab
reviewed
Jul 17, 2017
| @@ -0,0 +1,57 @@ | |||
| extends Node2D | |||
|
|
|||
| const line_width = 10 | |||
There was a problem hiding this comment.
Not sure about coding conventions for gdscript, but constants should be named in CAPS.
pwab
reviewed
Jul 17, 2017
| # Creates 2 points each for start and end point of a line; | ||
| # these points make up the corners of the rectangle that is the line representation. | ||
|
|
||
| width = width / 2 |
There was a problem hiding this comment.
Here should be a short comment, what this line means.
|
Superseded by #89, this should be closed. |
|
Thanks, closing as superseded by #89 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.