-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert physics test projects to 4.0 #638
Convert physics test projects to 4.0 #638
Conversation
Switched to draft because I noticed a couple things I can still fix before merging. |
cbc1578
to
67d1682
Compare
67d1682
to
d5c8091
Compare
Everything should be ready now, I've fixed the last remaining issues. |
d5c8091
to
e7e6f97
Compare
I've just updated the 2D character tests with needed changes from godotengine/godot#51027 and also replaced references to Kinematic Body to Character Body in the scripts and UI. |
e7e6f97
to
90ae5cc
Compare
Updated with changes from godotengine/godot#51490: no more ray shapes and added new CharacterBody parameters instead. |
31a62e3
to
9cec4ef
Compare
9cec4ef
to
dde088c
Compare
dde088c
to
87aefe7
Compare
2da375a
to
bf045e6
Compare
bf045e6
to
52f5b2e
Compare
Everything seems to work except for a few specific issues.
I'm listing all the changes I've made in case it helps for future conversions and for keeping track of possible issues for users.
General changes:
Control
nodes:margin_*
renamed tooffset_*
@export
,@export_range
,@tool
,@onready
Callable
await
instead ofyield
, no morecompleted
signalsuper
calls in built-on functions to call the parent script when neededempty()
tois_empty()
in several classesStringName
toString
pause_mode
toprocess_mode
material_override
inGeometryInstance3D
, need to useset_surface_override_material()
inMeshInstance3D
insteadImmediateGeometry
node withMeshInstance3D
node andImmediateMesh
resourceBUTTON_*
toMOUSE_BUTTON_*
scancode
tokeycode
OS.get_ticks_usec()
toTime.get_ticks_usec()
instance()
toinstantiate()
DisplayServer.window_get_mode()
andDisplayServer.window_set_mode()
instead ofOS.window_fullscreen
window/stretch/mode
:canvas_item
instead of2d
Slider
anymore, need to useHSlider
orVSlider
TileMap
collisions were offseted and cell size was resetPhysics specific changes:
RectangleShape2D
node:extents
renamed tosize
and values doubledKinematicBody
->CharacterBody
for character controllersKinematicBody
->StaticBody
withkinematic_motion
for moving platformsGodotPhysics
engine string toGodotPhysics2D
andGodotPhyics3D
MODE_RIGID
toMODE_DYNAMIC
inRigidBody
move_and_slide()
RigidBody2D
due to increased default gravityNotes:
Regression in "Character - TileMap": one-way collision are not working at the moment (PR: Fix one-way collision in Tilemap godot#51259).edit: fix is merged
Regression in "Character - Pixels": test case "floor detection with motion changes" fails.edit: just made a typo when updating a rectangle size, fixed now.
Rendering issue in "Character - Pixels": it was previously using aViewport
node with lower resolution. It's all blurry now and I didn't find how to properly set pixelated rendering in 4.0.edit: fixed by setting
size_2d_override
andsize_2d_override_stretch
inSubViewport