Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for the GDScript documentation comments #3892

Merged

Conversation

ThakeeNathees
Copy link
Contributor

Documentation for the GDScript documentation comment. the implementation : godotengine/godot#41095

@ThakeeNathees ThakeeNathees force-pushed the gdscript-documentation-comments branch 3 times, most recently from 594b8a9 to 92c29ff Compare August 12, 2020 12:55
@NathanLovato NathanLovato added content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features and removed enhancement labels Oct 10, 2020
@NathanLovato NathanLovato added this to the Godot 4.0 milestone Oct 10, 2020
so it's possible to align and format the documentations and in addition color texts, images, fonts, tables,
urls, animation effects, etc. could be added with the :ref:`bbcode <doc_bbcode_in_richtextlabel>`.

Godot's class reference supports BBCode-like tags. They add nice formatting to the text which could also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BBCode is already documented. Please change this to link to the existing BBcode documentation so it's not duplicated.

@ThakeeNathees
Copy link
Contributor Author

I've committed the suggestions @balloonpopper thanks for the nitpicks

@ThakeeNathees
Copy link
Contributor Author

@Calinou done, thanks for the nitpicks, I'll resolve the merge conflicts once after the doc-comment is merged

@aaronfranke
Copy link
Member

@ThakeeNathees The GDScript documentation system has been merged, so this can be rebased now and merged soon.

(thanks @baloonpopper and @Calinou for the nitpicks)

Co-ayuthored-by: balloonpopper<5151242+balloonpopper@users.noreply.github.com>
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@ThakeeNathees
Copy link
Contributor Author

Rebased with the master (sorry for late)

@mhilbrunner mhilbrunner dismissed Calinou’s stale review July 12, 2021 11:41

Requested changes were implemented

@mhilbrunner
Copy link
Member

Sorry this has been gathering dust for a while - I wish all new engine features were documented by the contributors this thoroughly :) Good work!

Seem all requested changes were implemented, I built and checked this locally. Seems good!

@mhilbrunner mhilbrunner merged commit 0ecdd19 into godotengine:master Jul 12, 2021
@mhilbrunner
Copy link
Member

Thanks for the work and sorry this took a bit. Again, good work!

@ThakeeNathees ThakeeNathees deleted the gdscript-documentation-comments branch July 16, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants