Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# setup for linux for nuget packages see issue #41306 in godotengine/godot #3903

Closed
wants to merge 1 commit into from

Conversation

Duehok
Copy link

@Duehok Duehok commented Aug 17, 2020

Adds what I understood from #41306: godotengine/godot#41306
to use nuget packages, C# on linux needs mono 6.12+ (preview version) and nuget.exe installation

I am guessing that it is also true on MacOS, but I have not tested on this system!

Applies to 3.2
I remember having read that there are changes coming in 4.0 about how the C# assemblies are handled, so these changes might not apply to 4.0 but I have not tested.

Also, link to the impacted page:
https://docs.godotengine.org/en/stable/getting_started/scripting/c_sharp/c_sharp_basics.html

@Duehok
Copy link
Author

Duehok commented Aug 21, 2020

These changes might be made obsolete by
godotengine/godot#41408

I'd like to keep this PR open until there is at least a 3.2.3 RC with the changes included. Then the whole C# setup page will need a good cleanup.

@akien-mga
Copy link
Member

Can you check with https://godotengine.org/article/release-candidate-godot-3-2-3-rc-6 and adapt the docs accordingly?

BTW, release-specific or time-based references like "as of Godot 3.1 beta 3" (incredibly outdated by now) should really be avoided.

@akien-mga akien-mga requested a review from neikeq September 9, 2020 10:15
@akien-mga
Copy link
Member

BTW, pull requests should be made against the master branch as required in the PR template. This change is valid for both Godot 4.0 and Godot 3.2.x, so it will be cherry-picked manually for the stable branch once merged in master.

@neikeq
Copy link
Contributor

neikeq commented Sep 9, 2020

You don't need Mono 6.12+ unless there's something I'm missing. You don't need nuget.exe either as we use msbuild /restore.
IMO this page should make it clear that you only need MSBuild which can be obtained from different sources. On Linux/macOS those would be:

  • Mono (on Linux one must make sure it includes MSBuild, as it may come in a different package)
  • .NET Core SDK

On Windows there's also Visual Studio (or its Build Tools subset) and Rider's bundled MSBuild.

@NathanLovato
Copy link
Contributor

What's the status on this PR? Is it still relevant or should we close it?

@aaronfranke
Copy link
Member

This article still needs updating, but most of the changes in this PR aren't good. The repository this PR is based on has been deleted so this PR is invalid, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants