Improve phrasing of constants in GDScript basics #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Sep 18, 2020
There was a problem hiding this comment.
I'm not sure if the new formulation is actually an upgrade, as it no longer mentions the requirement that constants should have a value known at compile-time. (By definition, excludes things such as random values or OS-specific values.)
My suggestion might not be the best way to phrase it, but we need to change something before this can be merged.
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
|
Thanks, I added your suggestions to the PR |
|
Thanks 🙂 That said, #3623 is also overhauling that page. |
|
I just checked the changes in #3623 and they don't conflict with these ones. Vnen didn't edit the first paragraph below the Constants heading. |
Calinou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a user's request on the Discord server's documentation channel.