Add macOS exporting and running pages. #5105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
force-pushed
the
mac_export_and_run
branch
3 times, most recently
from
d3f7bac
to
345537e
Compare
|
Singing is optional btw… but it helps maintain morale 😉 |
bruvzg
force-pushed
the
mac_export_and_run
branch
from
345537e
to
8cb305c
Compare
mhilbrunner
reviewed
Nov 3, 2021
… code signing info.
bruvzg
force-pushed
the
mac_export_and_run
branch
from
8cb305c
to
17be494
Compare
|
I have applied all suggested changes.
No, everything macOS seems to be done. |
|
Wow, amazing work - and that was fast :) Thanks a ton! |
This was referenced Dec 5, 2021
akien-mga
reviewed
Dec 21, 2021
Comment on lines
+14
to
+27
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>com.apple.security.device.audio-input</key> | ||
| <true/> | ||
| <key>com.apple.security.device.camera</key> | ||
| <true/> | ||
| <key>com.apple.security.cs.disable-library-validation</key> | ||
| <true/> | ||
| <key>com.apple.security.get-task-allow</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> |
There was a problem hiding this comment.
@bruvzg Should this be updated too after godotengine/godot#54067 ?
There was a problem hiding this comment.
Yes, should be full set of entitlements from #54067 plus:
<key>com.apple.security.get-task-allow</key>
<true/>
|
Cherry-picked for 3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Fixes #5076, #5066, #4927, #2739