Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Particles Documentation #5535

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Conversation

and-rad
Copy link
Contributor

@and-rad and-rad commented Jan 20, 2022

This adds a new page to the documentation, covering 3D particle systems.

  • Emitter properties
  • ParticlesMaterial properties
  • Sub emitters
  • Trails
    • Ribbons
    • Tubes
    • Skinned meshes (buggy, will be handled in separate PR)
  • Collision
    • Box
    • Heightfield
    • SDF
    • Sphere
  • Attractors
    • Box
    • Sphere
    • Vector field
  • Complex emission shapes
  • Turbulence (waiting to be merged and maybe improved)
  • Viewport menu
    • Create emission points from node
    • Convert to CPUParticles3D
  • Split docs into multiple pages

There is also this companion project that I used to create every screenshot used in the documentation:
https://github.com/and-rad/GodotDocParticles

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are definitely on the right track! This is looking great so far. I'm looking forward seeing to the rest of your progress

@and-rad
Copy link
Contributor Author

and-rad commented Jul 18, 2022

Small heads up: It might look like I'm not making any progress lately, but that's just me waiting for 4.0 to become a little more feature-complete. I've had to redo some screenshots and gifs multiple times already since I started writing the docs because names and features have changed in the meantime. And with godotengine/godot-proposals#3588 probably getting implemented, I'll have to reorganize a lot of what's already written.

So in an effort to not have to do too many do-overs, I'm keeping the particle docs on the back burner, but I'll pick up the pace again as soon as 4.0 nears RC status.

@clayjohn
Copy link
Member

@and-rad Sounds great! Thanks for letting us know. I look forward to when you return to this PR :)

@and-rad
Copy link
Contributor Author

and-rad commented Jul 20, 2022

Gonna link godotengine/godot#61014 here. Even though it doesn't currently work, I have documented the feature as if it did. I expect it'll be fixed in time for the 4.0 release.

@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Jan 13, 2023
@and-rad and-rad force-pushed the particles branch 2 times, most recently from ebc7fa7 to 409c190 Compare February 27, 2023 17:47
@and-rad and-rad changed the title [WIP] Add 3D Particles Documentation Add 3D Particles Documentation Feb 27, 2023
@and-rad and-rad marked this pull request as ready for review February 27, 2023 17:50
@Calinou
Copy link
Member

Calinou commented Mar 13, 2023

Gonna link godotengine/godot#61014 here. Even though it doesn't currently work, I have documented the feature as if it did. I expect it'll be fixed in time for the 4.0 release.

This wasn't fixed for 4.0's release, so I suggest adding a warning block to mention that the feature won't work yet.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is very good and complete, thanks a lot for going through this effort!

There are some changes that should be made to page and reference names though. Page names should use snake_case as per convention, and reference names should follow the file names (with parents included if there's possible ambiguity with other pages in the documentation).

Some page names should also be changed for better SEO, and so that they make more sense when viewed individually.

Here's a list of proposed changes (old → new):

  • complexshapes.rstcomplex_shapes.rst
  • doc_complexemissionshapes3ddoc_3d_particles_complex_shapes
  • creation.rstcreating_a_3d_particle_system.rst
  • doc_particlecreation3ddoc_creating_3d_particle_system
  • doc_particles3ddoc_3d_particles
  • doc_particleprocessmaterial3ddoc_process_material_properties
  • doc_particleattractors3ddoc_3d_particle_attractors (also rename the page to "3D particle attractors", and add a note that 2D particle attractors aren't implemented yet)
  • doc_particlecollision3ddoc_particle_collision_3d
  • doc_particleproperties3ddoc_particle_properties_3d
  • doc_subemitters3ddoc_subemitters_3d (also rename the page to "Particle sub-emitters" with a hyphen)
  • doc_particletrails3ddoc_particle_trails_3d
  • doc_particleturbulence3ddoc_particle_turbulence_3d (also rename the page to "Particle turbulence"

@and-rad
Copy link
Contributor Author

and-rad commented Mar 14, 2023

Done. I deviated from some of your suggestions when I felt it would improve consistency, but I think I got the important parts right.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@mhilbrunner
Copy link
Member

mhilbrunner commented Apr 17, 2023

Great work! PNGs need to be converted to WebP, but I can do that if you don't want to, seeing how long this been staying open :)

Edit: The PR actually contains WebPs, but PNGs too, we need to get rid of the latter.

@and-rad
Copy link
Contributor Author

and-rad commented Apr 17, 2023

I'll take care of it. I switched to webp halfway through after the decision was made to use the format from now on, but I didn't bother converting the old stuff. I'll replace the gifs with webp too.

@Calinou
Copy link
Member

Calinou commented Apr 30, 2023

I've amended this PR to document performance caveats of turbulence as per godotengine/godot#76501.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@Calinou Calinou merged commit 3323995 into godotengine:master Apr 30, 2023
@and-rad and-rad deleted the particles branch May 11, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants