Update compiling_for_android.rst #6115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Aug 27, 2022
Calinou
reviewed
Aug 27, 2022
| Compiling the editor is done by calling SCons from the Godot | ||
| root directory with the following arguments: | ||
|
|
||
| - Release Debug target (the editor will **only** compile with the **release debug** target.) |
There was a problem hiding this comment.
I'd remove this notice as target=debug can also be used. It's better for actual debugging as it provides full debug symbols and less optimization (optimization can mess up with debuggers).
The only target that currently can't be used is target=release, but this may change if godotengine/godot#60355 is merged.
There was a problem hiding this comment.
I removed the notice as requested. You are correct that there are additional targets that the editor can be built on.
Calinou
reviewed
Aug 27, 2022
Calinou
reviewed
Aug 27, 2022
mhilbrunner
approved these changes
Aug 27, 2022
mhilbrunner
approved these changes
Aug 28, 2022
|
Thank you, and congrats on your first contribution to Godot's docs! 🎉 |
rsubtil
pushed a commit
to rsubtil/godot-docs
that referenced
this pull request
Apr 11, 2023
* Update compiling_for_android.rst * Apply suggestions from code review * Update compiling_for_android.rst Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated 'compiling_for_adroid.rst' to include instructions on how to compile the Godot Editor for Android.
Bugsquad edit: salvages #6089