Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page on custom performance monitors #6409

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 21, 2022

There's probably a bit more information that could be added, but I'm not too sure what to add right now.

Original pull request adding the feature: godotengine/godot#39302

See #5121.

PS: I noticed that negative values are supported in the Performance singleton, but the editor doesn't graph them correctly. We should look into fixing this.

@Calinou Calinou added enhancement content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features labels Nov 21, 2022
@Calinou Calinou force-pushed the add-custom-performance-monitors branch from ac5b557 to fcedaec Compare November 21, 2022 23:21
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I only have 1 issue.

tutorials/scripting/debug/custom_performance_monitors.rst Outdated Show resolved Hide resolved
@Calinou Calinou force-pushed the add-custom-performance-monitors branch from fcedaec to 2d02728 Compare December 12, 2022 09:21
@Calinou Calinou merged commit 62c1050 into godotengine:master Dec 19, 2022
@Calinou Calinou deleted the add-custom-performance-monitors branch December 19, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content:new page Issues and PRs related to creation of new documentation pages for new or undocumented features enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants