Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 01.game_setup.rst key binding on Mac #6482

Merged
merged 1 commit into from
May 5, 2023

Conversation

3mdistal
Copy link
Contributor

I noticed while building my first game that grid snapping is also the ctrl key on macOS.

@YuriSizov
Copy link
Contributor

If it's the same, we don't need to put it in parentheses at all. But this may actually be a bug in the editor, if the key binding was intended to be Cmd on macOS.

@3mdistal
Copy link
Contributor Author

3mdistal commented Dec 12, 2022

That's what I wondered, too, about the bug. Unfortunately, I don't have enough expertise with Godot at the moment to be able to tell. I would say, though, that ctrl is generally a better binding on Mac, so that other programs don't interfere.

@3mdistal 3mdistal changed the title Update 01.game_setup.rst Update 01.game_setup.rst key binding on Mac Dec 12, 2022
@Calinou Calinou added the bug label Dec 13, 2022
@skyace65 skyace65 added the area:getting started Issues and PRs related to the Getting Started section of the documentation label Dec 28, 2022
@Vennnot
Copy link
Contributor

Vennnot commented May 3, 2023

If this is a possible bug in the editor, does it belong here? A bug ticket would have to be created and depending on the resolution then we can re-open this ticket.

@mhilbrunner
Copy link
Member

Relevant RC conversation:

mhilbrunner
Can someone on Mac confirm whether you use CMD or CTRL for grid snapping? re: #6482

bruvzg
It's CTRL (hardcoded to CTRL in various canvas editor places - https://github.com/godotengine/godot/blob/8c729f0f34a92b92a1a8204e1d56b6ad05cfd27b/editor/plugins/canvas_item_editor_plugin.cpp#L352). But probably should be changed to CMD since CTRL+click is right click on macOS, so it's only usable if you click first and ten press CTRL, otherwise it will open popup menu.

ajreckof
I think this be CMD I had one to change all those problem but I forgot to update since 4.0 I need to remove some rename that breaks compatibility #71905. After removing the rename I will recheck every type ctrl is used to determine whether it should be removed or not.
I think I was unsure at the time whether to include snapping in it but now that I rethink about it it is obvious it should be changed

Co-authored-by: Alice Alexandra Moore <86723305+3mdistal@users.noreply.github.com>
@mhilbrunner mhilbrunner merged commit e834796 into godotengine:master May 5, 2023
@mhilbrunner
Copy link
Member

Rebased and edited to remove the invalid keybinding mention for now until we fix that.

Thanks for contributing, and congrats on your first merged docs contribution! Sorry this has been sitting for so long, thats unfortunately due to a mixture of us lacking Mac contributors and the 4.0 backlog. :)

@3mdistal 3mdistal deleted the patch-1 branch May 5, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants