Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev=yes in unit testing guide #7596

Merged

Conversation

catwasd
Copy link
Contributor

@catwasd catwasd commented Jul 1, 2023

Description

This PR fixes the outdated usage of dev=yes in contributor guide.

Tests are compiled automatically if you use the dev=yes SCons option. dev=yes is recommended if you plan on contributing to the engine development as it will automatically treat compilation warnings as errors. The continuous integration system will fail if any compilation warnings are detected, so you should strive to fix all warnings before opening a pull request.

Link: https://docs.godotengine.org/en/stable/contributing/development/core_and_modules/unit_testing.html

PR that changed the option: godotengine/godot#66242

It is found in 4.0, 4.1, latest, and stable.

@mhilbrunner mhilbrunner added bug area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem cherrypick:4.0 cherrypick:4.1 labels Jul 19, 2023
@mhilbrunner mhilbrunner merged commit 19ec6ac into godotengine:master Jul 19, 2023
1 check passed
@mhilbrunner
Copy link
Member

Thanks! Merged. Sorry this has been sitting for a bit without response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation bug topic:buildsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants