Update Best practices documentation for Godot 4.1 #7640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
area:manual
Calinou
force-pushed
the
update-best-practices
branch
from
d68d642
to
2010948
Compare
mhilbrunner
approved these changes
Jul 18, 2023
|
@Calinou LGTM, but needs a rebase |
Note that the Data preferences page is still marked as outdated, as the internal implementation of Dictionary/HashMap has changed in Godot 4.0.
Calinou
force-pushed
the
update-best-practices
branch
from
2010948
to
dbcbceb
Compare
|
@Calinou Thanks for the rebase, merged. I've marked it for cherry-picking to 4.1 only for now due to the title, please add 4.0 if thats a wrong assumption and it is also applicable to 4.0. |
This should be all relevant for Godot 4.0 too 🙂 |
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the Data preferences page is still marked as outdated, as the internal implementation of Dictionary/HashMap has changed in Godot 4.0. This is complex to grasp; I may take a look at it later.