Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for updating a GDExtension for Godot 4.1 #7656

Merged

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Jul 13, 2023

This follows up on #7611 to add some more detailed instructions for updating a GDExtension for Godot 4.1.

I'm not entirely sure I'm showing the C++ changes in the most understandable way. With the incomplete syntax highlighting it's really hard to immediately see difference between the two code snippets. If anyone has any suggestions on how to make it clearer, please let me know!

@dsnopek dsnopek added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 labels Jul 13, 2023
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking over it, this looks great. Not sure if we need to also mention that there will be a new branch of godot-cpp named 4.1 to checkout?

@dsnopek dsnopek force-pushed the updating_gdextension_godot_4_1 branch from a5ad1b6 to 6617088 Compare July 17, 2023 14:46
@dsnopek
Copy link
Contributor Author

dsnopek commented Jul 17, 2023

Thanks!

I've added a small note regarding the 4.1 branch of godot-cpp

@mhilbrunner mhilbrunner merged commit 05cf055 into godotengine:master Jul 18, 2023
1 check passed
@mhilbrunner
Copy link
Member

Thanks! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants