Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GDExtension C++ tutorial to explain compatibility and point out Godot 4.1 breakage #7699

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Jul 20, 2023

These changes attempt to address a critique of this page from here.

The issues that were called out there revolve around the compatibility breakage between GDExtensions for Godot 4.0 and 4.1.

My changes here attempt to explain generally how compatibility is meant to work with GDExtension, as well as its current status as experimental, and a link to more detailed information around the specific 4.0 -> 4.1 breakage.

Please let me know what you think!

@dsnopek dsnopek added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.1 labels Jul 20, 2023
@dsnopek dsnopek requested a review from paddy-exe July 20, 2023 14:39
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

As a sidenote:
This doesn't really involve part of this PR but I do wonder if we have to change the branch info for every minor version after the system will be stable?

@dsnopek
Copy link
Contributor Author

dsnopek commented Jul 20, 2023

I do wonder if we have to change the branch info for every minor version after the system will be stable?

I'm hoping that we won't, because that'll be annoying to maintain :-)

For now, the page is still saying it's using 4.1 as an example, but if this continues to confuse people, I guess we may have to keep updating it every minor version. We'll see if any new issues get opened about it in 4.2!

@mhilbrunner mhilbrunner merged commit 31ac9bc into godotengine:master Jul 22, 2023
1 check passed
@mhilbrunner
Copy link
Member

@dsnopek Great work, merged. Any reason this should not be also cherry-picked to 4.0? Even if it uses 4.1 as an example, all this should be relevant to all 4.x versions when creating GDExtensions, right?

@dsnopek
Copy link
Contributor Author

dsnopek commented Jul 22, 2023

Thanks!

Well, it links to the "Updating to 4.1" page which I don't think is present in the 4.0 docs. But if that bit were remove, yes, I guess this is relevant for 4.0 as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants