Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Static typing in GDScript" page #8130

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Oct 2, 2023

@dalexeev dalexeev added enhancement topic:gdscript area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 2, 2023
@dalexeev dalexeev force-pushed the gds-update-static-typing branch 2 times, most recently from e45cd5d to f581734 Compare October 2, 2023 19:01
@ryanabx
Copy link

ryanabx commented Oct 3, 2023

Oops, I should have checked the pull requests before making one of my own, haha

@allenwp
Copy link
Contributor

allenwp commented Oct 3, 2023

If you prefer static typing, we recommend enabling the Text Editor > Completion > Add Type Hints editor setting. Also consider enabling some warnings that are disabled by default.

I really like this addition! Thanks for this :)

:ref:Clobal classes <doc_gdscript_basics_class_name>.

I think this is supposed to be "Global classes" (under the "What can be a type hint" heading)

@allenwp
Copy link
Contributor

allenwp commented Oct 3, 2023

As you were working on this pull request, I was also working on a blog post that was intended to be a supplemental document to the Static typing in GDScript page. Your proposed changes in this PR helped me improve my blog post! Thanks!

In case my blog post helps inform this docs update, here it is.

@dalexeev dalexeev force-pushed the gds-update-static-typing branch from f581734 to 9eb7aa3 Compare October 6, 2023 09:49
@mhilbrunner mhilbrunner merged commit 17f0da6 into godotengine:master Oct 6, 2023
1 check passed
@mhilbrunner mhilbrunner added this to the 4.2 milestone Oct 6, 2023
@dalexeev dalexeev deleted the gds-update-static-typing branch October 6, 2023 10:46
@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 6, 2023

Thanks! Merged. 🎉 Also closed the other PR as superseded. You've been on fire with GDScript docs, great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:gdscript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically cast parameter throws "Cannot convert argument 1 from Object to Object" error
4 participants