Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new denoisers and properties in Using Lightmap global illumination #8273

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 18, 2023

This also updates List of features to be up-to-date with Godot 4.2's 3D rendering features.

Don't cherry-pick, as this documents features not present in 4.1.

Project used for new images: test_lightmap_denoise.zip

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 18, 2023
@skyace65 skyace65 added this to the 4.2 milestone Oct 19, 2023
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

about/list_of_features.rst Outdated Show resolved Hide resolved
about/list_of_features.rst Outdated Show resolved Hide resolved
about/list_of_features.rst Outdated Show resolved Hide resolved
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the above

…nation

This also updates List of features to be up-to-date with Godot 4.2's
3D rendering features.
@mhilbrunner mhilbrunner merged commit 548c600 into godotengine:master Oct 21, 2023
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@Calinou Calinou deleted the using-lightmaps-denoiser branch October 31, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants