Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the instructions in the compiling_for_android docs #8368

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Clean up the instructions in the compiling_for_android docs #8368

merged 1 commit into from
Nov 2, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Nov 1, 2023 •
edited by mhilbrunner
Loading

Edit: supersedes #8330

@m4gr3d m4gr3d added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation topic:buildsystem labels Nov 1, 2023
@m4gr3d m4gr3d added this to the 4.2 milestone Nov 1, 2023
@m4gr3d m4gr3d requested a review from mhilbrunner November 1, 2023 01:38
@m4gr3d m4gr3d mentioned this pull request Nov 1, 2023
Closed
@m4gr3d
- Update the JDK version for Godot Android development
7db7cc9 
- Update the env variable pointing to the Android SDK
@m4gr3d m4gr3d force-pushed the update_jdk_version branch from 55eddcb to 7db7cc9 Compare November 1, 2023 16:21
@m4gr3d m4gr3d changed the title Update the JDK version for Godot Android development Clean up the instructions in the compiling_for_android docs Nov 1, 2023
@mhilbrunner mhilbrunner marked this pull request as draft November 2, 2023 00:43
@mhilbrunner
Copy link
Member

LGTM, marked as draft until godotengine/godot#84316 is merged. Once that PR is merged, please ping me for a merge here :) Thanks!

@m4gr3d
Copy link
Contributor Author

m4gr3d commented Nov 2, 2023

@mhilbrunner godotengine/godot#84316 has been merged!

@mhilbrunner mhilbrunner marked this pull request as ready for review November 2, 2023 19:54
@mhilbrunner mhilbrunner merged commit ef633e9 into godotengine:master Nov 2, 2023
1 check passed
@mhilbrunner
Copy link
Member

Wheee! In this goes. Thanks a bunch. :)

@mhilbrunner mhilbrunner mentioned this pull request Nov 2, 2023
Closed
@m4gr3d m4gr3d deleted the update_jdk_version branch November 3, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@m4gr3d @mhilbrunner