-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Upgrading from Godot 4.2 to Godot 4.3" page #9250
Conversation
9004071
to
ac20c42
Compare
ac20c42
to
b0f4fa8
Compare
b0f4fa8
to
82a6107
Compare
I have updated the list to commit godotengine/godot@26d1577. I would appreciate a review of the behavior changes from the respective area maintainers. I'm not involved in these areas and I likely didn't get it right.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Android updates look good.
The TileMap changes look good to me. |
@raulsntos is this ready for review or do more changes need to be made? |
82a6107
to
2a8cdbb
Compare
I've addressed the feedback from the previous reviews, and updated the list of breaking changes after godotengine/godot#94291. I'd still like the behavior changes to be reviewed by the respective area maintainers, mainly the rendering area. But I can probably take it out of draft now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackedByteArray changes look good.
2a8cdbb
to
44e89b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Animation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor issue.
44e89b2
to
6571806
Compare
6571806
to
305eca6
Compare
@raulsntos I see you just pushed some more changes today. Do you still need to do work on this or is it good to merge? |
Yes, the latest changes were suggested in the development chat. Further changes can be made as follow-up PRs. |
Thanks! |
It's that time of the year again. This documents all the breaking changes in 4.3, like we did for 4.2 (#8488), and 4.1 (#7611).
Area maintainers should review the changes listed for their area. Also feel free to suggest any addition that I might have missed or make follow-up PRs.
Updated as of commit godotengine/godot@26d1577
Bugsquad edit: Preview: https://github.com/raulsntos/godot-docs/blob/breaking_changes_4.3/tutorials/migrating/upgrading_to_godot_4.3.rst