Fresh "How to contribute" page #9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This page was so old, it still listed Juan as the lone core developer. Rewritten from scratch to reflect the different avenues of support, including funding and non-tech contributions.
AThousandShips
added
enhancement
cherrypick:3.5
cherrypick:3.6
area:contributing
|
Looks good after a first read. The link to this file in |
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
MurderVeggie
commented
Jul 15, 2024
MurderVeggie
commented
Jul 15, 2024
Sauermann
reviewed
Jul 15, 2024
skyace65
requested changes
Jul 15, 2024
Piralein
requested changes
Jul 16, 2024
Co-authored-by: Hana - Piralein <48352564+Piralein@users.noreply.github.com>
Co-authored-by: Hana - Piralein <48352564+Piralein@users.noreply.github.com>
Co-authored-by: Hana - Piralein <48352564+Piralein@users.noreply.github.com>
Co-authored-by: Hana - Piralein <48352564+Piralein@users.noreply.github.com>
MurderVeggie
commented
Jul 16, 2024
MurderVeggie
commented
Jul 16, 2024
skyace65
requested changes
Jul 17, 2024
clayjohn
reviewed
Jul 18, 2024
There was a problem hiding this comment.
Looks great! I left a few suggestions.
When building locally I also noticed there is one more place that needs to be updated:
https://github.com/godotengine/godot-docs/blame/10e686a376ff3c1013fe6f5049c3b80892b5e86f/index.rst#L134
Still says: contributing/ways_to_contribute but it should now be contributing/how_to_contribute. I think this section uses the actual file name, so the redirect doesn't catch it
Piralein
requested changes
Jul 18, 2024
Sauermann
reviewed
Jul 19, 2024
Co-authored-by: Clay John <claynjohn@gmail.com>
Co-authored-by: Markus Sauermann <6299227+Sauermann@users.noreply.github.com>
Co-authored-by: Clay John <claynjohn@gmail.com>
removed duplicate link names updated index.rst included conversation feedback
…odot-docs into how-to-contribute
AThousandShips
approved these changes
Jul 19, 2024
| To let us know about your findings, fill out this `bug report form <https://github.com/godotengine/godot/issues/new/choose>`_ on our GitHub. | ||
| Make sure to include as much information as possible to ensure these issues can easily be reproduced by others. | ||
|
|
||
| If you are interested in helping keep our bug tracker organized, you can even join the `bugsquad <https://chat.godotengine.org/channel/bugsquad>`_! |
There was a problem hiding this comment.
Suggested change
| If you are interested in helping keep our bug tracker organized, you can even join the `bugsquad <https://chat.godotengine.org/channel/bugsquad>`_! | |
| If you are interested in helping to keep our bug tracker organized, you can even join the `bugsquad <https://chat.godotengine.org/channel/bugsquad>`_! |
There was a problem hiding this comment.
I believe language wise the version without "to" sounds smoother, although both are correct.
There was a problem hiding this comment.
To me it sounds ungrammatical, but the whole sentence is a bit clunky, alternatively this:
Suggested change
| If you are interested in helping keep our bug tracker organized, you can even join the `bugsquad <https://chat.godotengine.org/channel/bugsquad>`_! | |
| You can even join the `bugsquad <https://chat.godotengine.org/channel/bugsquad>`_ if you want to help keep our bug tracker organized! |
To make it flow better
Piralein
approved these changes
Jul 19, 2024
clayjohn
approved these changes
Jul 19, 2024
|
Merged! Thank you everyone for the extra pairss of eyes. Will make sure to keep this updated from now on. |
mhilbrunner
pushed a commit
that referenced
this pull request
Jul 24, 2024
Fresh "How to contribute" page (cherry picked from commit 86192a2)
|
Cherry-picked to 4.2 in #9648. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original page was so old, it still listed Juan as the lone core developer. Rewritten from scratch to reflect the different avenues of support, including funding and non-tech contributions.
This page is directly linked to the "Contribute" button on the main website, by the way.