Fix error when unstaging file with no HEAD commit #100 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes an issue with diffing staged files when there is no previous HEAD commit
twaritwaikar
force-pushed
the
fix-unstage-when-no-initial-commit
branch
from
5cdf582
to
acc0901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes an issue with diffing staged files when there is no previous HEAD commit.
Under the issue, I have also mentioned that the Godot editor may need a change to be able to recover from the case when an unstaging/staging does not succeed. However, it seems that handling that error inside the plugin is easier to handle. So for now we can leave the editor as is, or at least for solving this particular issue.
Fixes #100