Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The ability to Limit(constraints) IK #3712

Closed
Tracked by #1
ywmaa opened this issue Dec 23, 2021 · 7 comments
Closed
Tracked by #1

The ability to Limit(constraints) IK #3712

ywmaa opened this issue Dec 23, 2021 · 7 comments

Comments

@ywmaa
Copy link

ywmaa commented Dec 23, 2021

Describe the project you are working on

I am working on creating Advanced Movement System Godot 3D template

and I am using SkeletonModificationStack for IK system

Describe the problem or limitation you are having in your project

SkeletonModification3DLookAt doesn't have an option to limit the rotation of the bone

for example : Iam using it for head rotation so the head can follow(Look at) a target ,
but if the target is for example behind the player this will make the head rotate 180 degrees

Describe the feature / enhancement and how it helps to overcome the problem or limitation

the feature to add a limit to bone rotation (constraint it) so it doesn't rotate it awkwardly

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

add an option

Bone limits (x,y,z)
and Enable/Disable option for this feature

If this enhancement will not be used often, can it be worked around with a few lines of script?

I believe it will be used a lot but
there is workaround though it isn't good :
like reducing the strength (but I want the head to look at the target not just tilt his head a little,

Is there a reason why this should be core and not an add-on in the asset library?

I don't think this small feature should be in a plugin while it could be directly in godot

@fire
Copy link
Member

fire commented Dec 23, 2021

I’ve been working on this, please contact me on discord for details. Still draft stage.

@ywmaa
Copy link
Author

ywmaa commented Dec 23, 2021

@fire do you need someone to test it ?

@fire
Copy link
Member

fire commented Dec 23, 2021

If you're able to help out test or able to provide sample case, that is welcome. It's also been difficult because of the different parts.

Edited:

Providing encouragement is great too!

@ywmaa
Copy link
Author

ywmaa commented Dec 24, 2021

here I am working on advanced movement system template

https://github.com/ywmaa/Advanced-Movement-System-Godot

it is the main reason why I requested this feature

I think I can test the feature as it is part of my project

@fire
Copy link
Member

fire commented Jan 6, 2022

I found an old IK Constraints proposal with some information #750

@Calinou
Copy link
Member

Calinou commented Jan 6, 2022

I found an old IK Constraints proposal with some information #3712.

You linked to the same proposal 🙂

@ywmaa
Copy link
Author

ywmaa commented Jan 11, 2022

if someone is working on this , here is my contribution to it :

#750 (comment)

and I am closing this issue because it is almost a duplicate of the issue above

and it has better explanation with better/more suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants