Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guideline for evaluating proposals #466

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

clayjohn
Copy link
Member

This adds a lot of clarification to the process used for selecting and rejecting proposals. This should assist users in writing proposals and should assist reviewers in applying clear and fair criteria to proposals.

All these considerations have been in use, and have been discussed among the core developers, but have not been formally verbalized yet.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to formalize this 🙂

I made some grammar suggestions below.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Xrayez
Copy link
Contributor

Xrayez commented Feb 12, 2020

3. Can this proposal be implemented with an addon?

Evaluate whether it is possible for the proposal to be implemented in an addon. The likelihood of such a proposal being accepted depends on the amount of expressed community support, but if the proposal is a good candidate to be implemented in an addon while not receiving much feedback for some prolonged amount time, advise the person to propose the feature via Community Channels such as godot-ideas repository instead, closing the proposal.

The linked repo can help/close #91.

I've already re-implemented some core features via GDScript, so I don't think that "if can be implemented as addon" is enough to justify the decision to close such a proposal.

8. Can the feature be worked around in script with a few lines?

If the feature is intended to save users a few lines of code it is unlikely to be accepted, unless it solves a very common use case which can help to improve the overall usability of the engine (QoL features).


Core developers have discretion to weigh the factors as they see fit.

🤷‍♂️

@clayjohn
Copy link
Member Author

I've already re-implemented some core features via GDScript, so I don't think that "if can be implemented as addon" is enough to justify the decision to close such a proposal.

Only guideline 1 (also rule 1) can be used to justify closing a proposal on its own. All guidelines are factors to be weighed when making a decision.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@clayjohn
Copy link
Member Author

@akien-mga This should be ready for final review/merging now.

Sorry for the long delay. I forgot about it completely. :P

@akien-mga akien-mga merged commit 1e7b1c9 into godotengine:master Mar 23, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants