-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for 45545 #21
Conversation
Hey @fire I started writing some tests for the change to/removal of |
I'll try to look near the weekend, don't wait for me. |
cf3ca19
to
8aa30b1
Compare
Still a little bit of work to be done, but I think this is ready for a first pass. Remaining bits:
|
Animation checking code is fixed, added a skeleton test. Emoji tests still fail without the patch from @bruvzg (as expected), but generate nodes that are referenceable if you know that the emoji chars will be replaced by the replacement chars (I'd propose leaving as is if the improvement to the JSON tokenizer is likely to be accepted). |
Is this ready to be merged? |
I think so. It looks like I can't add reviewers on this repo though (and there doesn't seem to be an automatically assigned reviewer like on the main repo). |
Thanks for contributing to Godot Engine. |
Adds automated tests for godotengine/godot#45545