Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the configuration item 'godot-tools.check_config' as it has no effect #246

Merged

Conversation

linkpy
Copy link
Contributor

@linkpy linkpy commented Oct 27, 2020

Fixes #240.

As said in the issue comment :

I don't know what is its initial intended behaviour. I think it's just to hide the indicator at the bottom right of the editor, since disabling the status check is not possible.

If you know the original intent of that option please let me know.

@pcting
Copy link

pcting commented Oct 28, 2020

👍

@Calinou Calinou added the bug label Oct 28, 2020
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou changed the title [#240] Removed the configuration item 'godot-tools.check_config' as it has no effect. Remove the configuration item 'godot-tools.check_config' as it has no effect Oct 28, 2020
@Calinou Calinou merged commit 116d74d into godotengine:master Oct 28, 2020
@linkpy linkpy deleted the 240-inconsistent-configuration-item-name branch October 28, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"godot-tools.check_status" inconsistency in package.json
3 participants