Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in launching debugger #371

Merged
merged 3 commits into from
May 28, 2022

Conversation

DaelonSuzuka
Copy link
Collaborator

A previous commit assembled the executable_line variable incorrectly, and added redundant local variables.

This is a fix for #370. I can confirm that in 1.3,0, launching is slower and breakpoints don't stop. This change fixes that regression.

However, on 1.2.0, 1.3.0, and this patch, continuing or stepping over/in/out of a stopped breakpoint doesn't seem to do anything. I have to admit I've never used the VSCode debugger until now, so I'm not sure if this is a known issue, a problem with my configuration, or another regression.

@DaelonSuzuka DaelonSuzuka changed the title Fix incorrect command building Fix regression in launching debugger May 25, 2022
@Exerionius
Copy link

Stepping over/in works for me in 1.2.0. Debugger also shows locals/members, call stack and scene tree correctly.
Editing variables at runtime also works in 1.2.0.

@DaelonSuzuka
Copy link
Collaborator Author

Stepping over/in works for me in 1.2.0. Debugger also shows locals/members, call stack and scene tree correctly.
Editing variables at runtime also works in 1.2.0.

You're using Godot 3.4.4, and I was on 3.5beta5. When I switch back to 3.4.3(the one I still had downloaded), I can continue breakpoints and also see locals/members.

I think this fixed it, but we really need somebody else to test it.

@atirut-w
Copy link

However, on 1.2.0, 1.3.0, and this patch, continuing or stepping over/in/out of a stopped breakpoint doesn't seem to do anything. I have to admit I've never used the VSCode debugger until now, so I'm not sure if this is a known issue, a problem with my configuration, or another regression.

Continue feature works for me but stepping features seem to also do nothing for me.

@DaelonSuzuka
Copy link
Collaborator Author

DaelonSuzuka commented May 25, 2022

@atirut-w What Godot version are you using?

@atirut-w
Copy link

v3.4.4.stable.official [419e713a2]. The stepping features seem to behave same as continue.

@DaelonSuzuka
Copy link
Collaborator Author

Okay, part of my problem was user error. Continue and stepping all appear to work on v3.4.3.stable.official.242c05d12.

Stepping in too much sometimes causes the whole thing to lock up, but I'm fairly confident that this either still my fault or an existing weirdness.

@Calinou I'm thinking the reported regression is fixed. Further investigation into the debugger interface is a very large task and I can't promise any sort of timetable. As long as @atirut-w (or you, or somebody other than me) tested this PR, then my recommendation is to merge and publish a patch version to get the most broken behavior away from users.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 372936b into godotengine:master May 28, 2022
@DaelonSuzuka DaelonSuzuka deleted the fix-debugger-command branch August 22, 2022 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants