Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launching the editor opens a new custom terminal #561

Merged

Conversation

DaelonSuzuka
Copy link
Collaborator

@DaelonSuzuka DaelonSuzuka commented Jan 2, 2024

Per feedback from @KoBeWi, this PR moves the process started by Open Workspace with Godot Editor back to a terminal (instead of a headless child process).

This time the terminal is implemented correctly, with a name + icon, and doesn't have a lingering prompt that you really shouldn't use. It also prints that the editor was stopped and what the exit code was.

image

Notes:

  • Killing the terminal in VSCode (trash can button) kills the Godot Editor.
  • Closing the Godot Editor does not kill the terminal, just in case there's some output you wanted to see.
  • Running Open Workspace with Godot Editor again will close any existing windows and start a new one. I don't see a reason to open the same workspace multiple times.
  • new settings:
    • godotTools.editor.verbose: Whether to launch the Godot Editor with the --verbose flag
    • godotTools.editor.reveal: Whether to reveal the terminal when launching the Godot Editor

@DaelonSuzuka DaelonSuzuka merged commit 4ae31bf into godotengine:master Jan 6, 2024
4 checks passed
@DaelonSuzuka DaelonSuzuka deleted the launch-editor-improvements branch January 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant