Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: No data when using typed arrays #699 #708

Closed
wants to merge 1 commit into from

Conversation

n4nn31355
Copy link

@n4nn31355 n4nn31355 commented Sep 4, 2024

Fixes #699 at least in some cases.

The current problem is that for some typed arrays their type is added to the buffer, but the extension doesn't handle it.

I'm not sure about my solution, but it fixes problem in my case.

Code to reproduce issue:

class_name MainLevel extends Node3D

func _ready() -> void:
    Performance.add_custom_monitor("custom/the/test", _get_calculation_performance)

func _unhandled_input(event: InputEvent) -> void:
    if event.is_action_pressed("ui_cancel"):
        _register_monitor()

func _register_monitor() -> void:
    Performance.add_custom_monitor("custom/the/test_more", _get_calculation_performance)

func _get_calculation_performance() -> float:
    return 0

@NathanNgo
Copy link

NathanNgo commented Sep 13, 2024

With Typed Dicts coming in soon, do you think it will break on that as well?

@DaelonSuzuka
Copy link
Collaborator

@n4nn31355 I have good news and bad news:

I'm not sure about my solution, but it fixes problem in my case.

Good news: Your solution is exactly correct, because it's almost line-for-line identical to what I wrote in #715
Bad news: I wrote and merged #715 without looking at open PRs, so I accidentally reimplemented your work and stole your thunder.

Thank you very much for submitting a fix, and I'm terribly sorry for wasting your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The debugger doesn't show any data
3 participants