Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newline when dropping nodes into editor #754

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

k-expon
Copy link

@k-expon k-expon commented Nov 15, 2024

After dropping nodes into editor, it required very little modification.
So I simply added a newline character at the end of @onready generation statements to avoid unnecessary manual line breaks.

@DaelonSuzuka
Copy link
Collaborator

Did you check the behavior of other "drag into editor" features?

@DaelonSuzuka
Copy link
Collaborator

DaelonSuzuka commented Nov 24, 2024

Oh, that's interesting! Dragging various things into markdown files gives you a snippet-like text insertion with a pre-selection.

It doesn't add an extra newline, though. I'll try to find some other examples.

Generally dragging a file into a document gives you the workspace-relative path of the dragged file, again with no newline.

@k-expon
Copy link
Author

k-expon commented Nov 26, 2024

Oh, that's interesting! Dragging various things into markdown files gives you a snippet-like text insertion with a pre-selection.

It doesn't add an extra newline, though. I'll try to find some other examples.

Generally dragging a file into a document gives you the workspace-relative path of the dragged file, again with no newline.

I haven't tested everything related to this, but at least the things you mentioned I've also checked and PR.
As you can see from the modified code, it's only affecting @onready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants