-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.3 release page (redux) #882
4.3 release page (redux) #882
Conversation
80f5307
to
503f6a7
Compare
I did a review and I like this way much better. There are a couple things that I would like to know more. I have a bunch of design updates I would like to make. For instance, you are using pure black for the font, the style is bright by default, and there is no dark theme version of it. Should I leave the feedback here or do you want me to send a commit to the repo directly? |
It may be worth switching to a variable font file, so we only need to ship a single file to support all weights (including in-between weights that were previously not supported). These are pretty well-supported by now. Not all fonts exist in variable form yet, but you might be able to find one for Montserrat. |
I didn't want to install NPM in the project, so I took the package itself and put it here, since I'm using a
Yes, it's for the missing weights and styles.
Sure, go ahead, and commit away! |
Good idea, I'll install one.
There's two for Montserrat, italic and standard. I think that I should be able to convert the variable TrueType font to WOFF2. |
Sent my first commit, but there's a lot more to be done. Changes:
To do on further updates:
|
0d6817e
to
c4d9245
Compare
66359c7
to
b6c9aa9
Compare
81565cc
to
67afed1
Compare
There's something else that, despite maybe not as exciting (because it's one of those things that you only notice when they malfunction), is worth mentioning: multiple threading enhancements; notably, more optimized and stable multi-threaded resource loading. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly language knitpicks, but also two raised flags in general.
-
the highlight class should be used more sparingly, and the words you choose need to be directly related to the feature and stand strong on their own, e.g. "audio resources" and not "your ears"
-
the c-titles are lowkey confusing, with the way they are formatted they seem more like subtitles to the c-blockquote, and I wouldn't have guessed them to be clickable either. you used them inconsistently throughout the page yourself, sometimes describing the area you are going to talk about (I changed all of them to match this as much as I could) and sometimes being full explanatory sentences
Lastly, since I couldn't find the matching code for this, please change Get yourself a copy of Godot 4.3… for free!
to a less easily misunderstood CTA
1. Inline code in light theme looks a bit strange, like you pasted screenshots from Godot editor as images. If it's not too much trouble, could you please adjust the background color for light theme? 2. Some inline code is highlighted and some is not. Not only keywords and annotations are highlighted, but also some regular methods. 3. Some cards contain changes from several authors at once, for example here the highlighting was added by me, and the copy button is Mickeon's. While the "Read more" link only directs to my PR. 4. The image for "Documentation pages of the editor can now link to themselves" is incorrect, godotengine/godot#91537 added 🔗 links to the online documentation, not to the built-in help. The description is also incorrect. 5. "Support for deprecated and experimental features" should be "Support for deprecated and experimental messages" or something like this. Support for deprecated/experimental marks in GDScript documentation was added in 4.2. In 4.3 we added the ability to provide messages to both core and GDScript documentation. 6. "GDScript circular dependencies between scenes and scripts" should be placed higher. In my opinion, this is a more important change, along with "Binary tokenization on export". And "is not operator" card should be smaller as it has little content. 7. There was also a notable PR from Hilderin fixing many 8. The description for "Built-in methods and utility functions usable as Callable" can be improved. In my opinion, built-in methods are more important than utility functions. Users often faced the problem that 9. Improved array export is no less important than 10. There is a missing background on some cards and headers (I don't know if anyone reported this above). There's also a weirdly highlighted exclamation mark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP review. Still need to do rendering copy
excerpt: "TODO: replace me" | ||
categories: ["release"] | ||
author: "Godot contributors" | ||
image: /storage/blog/covers/godot-4-2-arrives-in-style.webp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some recommended content for the rendering section as well as some corrections for the existing content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important rephrasings for marketing purposes
@dalexeev I found a fix for this issue, will correct it. Edit: no, finally, it's alright. I mixed up two features. |
662f56b
to
ccf8421
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch done
These are the points that the XR team decided we wanted to call out for the release at our meeting a couple days ago:
And here is an animated GIF that I made to go along with the first point about composition layers: No obligation to use it! It was the best I managed to capture attempting to show off the difference, but I know it's not the most visually stunning thing :-) Other members of the XR team are attempting to some media to go along with the other points as well. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5th batch of changes
8b1b0a8
to
f8d9376
Compare
@adamscott Thanks for the corrections, looks really good! 👍 It might be worth adding an image for the "Link to specific class references directly" card, as the text description may not be clear enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
member feedback & last batch of changes
@dalexeev Done! |
37ddcb2
to
8a73a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes on the latest text in the XR section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes about the GDExtension section
I believe you're missing this for the download links to actually work, and 4.3 to be featured on the homepage: diff --git a/_data/versions.yml b/_data/versions.yml
index dcad32804..396a46c36 100644
--- a/_data/versions.yml
+++ b/_data/versions.yml
@@ -1,8 +1,12 @@
- name: "4.3"
- flavor: "rc3"
- release_date: "8 August 2024"
- release_notes: "/article/release-candidate-godot-4-3-rc-3/"
+ flavor: "stable"
+ release_date: "15 August 2024"
+ release_notes: "/releases/4.3/"
+ featured: "4"
releases:
+ - name: "rc3"
+ release_date: "8 August 2024"
+ release_notes: "/article/release-candidate-godot-4-3-rc-3/"
- name: "rc2"
release_date: "1 August 2024"
release_notes: "/article/release-candidate-godot-4-3-rc-2/"
@@ -41,7 +45,6 @@
flavor: "stable"
release_date: "17 April 2024"
release_notes: "/article/maintenance-release-godot-4-2-2-and-4-1-4/"
- featured: "4"
releases:
- name: "rc3"
release_date: "12 April 2024" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small typo. I reviewed all the rendering and XR changes and they look great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typos and such, as well as feedback from @dsnopek & @raulsntos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback by @Riteo
@akien-mga Done! |
a61cfe9
to
587294c
Compare
3e6ba9b
to
f32b38d
Compare
- Web development by Adam Scott with help from Emilio Coppola - Design template by Luis Carli - Visuals by Adam Scott with speial thanks to GDQuest, Kenney, and FR3NKD - Texts by Nathalie Galla & Adam Scott Co-authored-by: Nathalie Galla <murderveggie@gmail.com> Co-authored-by: luiscarli <git@luiscarli.com> Co-authored-by: Emi <2206700+coppolaemilio@users.noreply.github.com> Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
f32b38d
to
44791d1
Compare
massive work everyone 😭 🙏 |
Warning
Work in progress
Follow-up to #878
Simplified the HTML code to more basic stuff.
Screenshot
Todo
Godot Foundation
Download
Outstanding features
C#
Documentation
GDExtension
GDScript
Navigation
Rendering
XR