Merge pull request #90791 from timothyqiu/see-you-again

Fix potential infinite loop when using global menu
godotengine · Apr 17, 2024 · acd3d24 · acd3d24
2 parents 8293aac + 43ed8d4
commit acd3d24
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/servers/display_server.cpp b/servers/display_server.cpp
@@ -212,7 +212,7 @@ String DisplayServer::global_menu_get_item_submenu(const String &p_menu_root, in
 	ERR_FAIL_NULL_V(nmenu, String());
 	RID rid = nmenu->get_item_submenu(_get_rid_from_name(nmenu, p_menu_root), p_idx);
 	if (!nmenu->is_system_menu(rid)) {
-		for (HashMap<String, RID>::Iterator E = menu_names.begin(); E;) {
+		for (HashMap<String, RID>::Iterator E = menu_names.begin(); E; ++E) {
 			if (E->value == rid) {
 				return E->key;
 			}