Merge pull request #79818 from garychia/select_all

RichTextLabel: Ensure the `select_all` function selects all items
godotengine · Aug 28, 2023 · b00796e · b00796e
2 parents 6da4ad1 + d66c7a2
commit b00796e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/scene/gui/rich_text_label.cpp b/scene/gui/rich_text_label.cpp
@@ -5310,6 +5310,8 @@ void RichTextLabel::selection_copy() {
 }
 
 void RichTextLabel::select_all() {
+	_validate_line_caches();
+
 	if (!selection.enabled) {
 		return;
 	}
@@ -5322,13 +5324,12 @@ void RichTextLabel::select_all() {
 		if (it->type != ITEM_FRAME) {
 			if (!from_item) {
 				from_item = it;
-			} else {
-				to_item = it;
 			}
+			to_item = it;
 		}
 		it = _get_next_item(it, true);
 	}
-	if (!from_item || !to_item) {
+	if (!from_item) {
 		return;
 	}