Skip to content

Commit

Permalink
Fix doc_status.py trying to get removed version tag from XML
Browse files Browse the repository at this point in the history
This also runs `doc_status.py` on CI to catch potential future regressions.
  • Loading branch information
Calinou committed Jul 13, 2023
1 parent 60f3b79 commit c16db09
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
1 change: 1 addition & 0 deletions .github/workflows/static_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ jobs:
- name: Documentation checks
run: |
doc/tools/doc_status.py doc/classes modules/*/doc_classes platform/*/doc_classes
doc/tools/make_rst.py --dry-run --color doc/classes modules platform
- name: Style checks via clang-format (clang_format.sh)
Expand Down
6 changes: 0 additions & 6 deletions doc/tools/doc_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,12 +383,6 @@ def generate_for_class(c: ET.Element):
tree = ET.parse(file)
doc = tree.getroot()

if "version" not in doc.attrib:
print('Version missing from "doc"')
sys.exit(255)

version = doc.attrib["version"]

if doc.attrib["name"] in class_names:
continue
class_names.append(doc.attrib["name"])
Expand Down

0 comments on commit c16db09

Please sign in to comment.