Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update position in animation editor #15646

Closed
thankjura opened this issue Jan 12, 2018 · 5 comments
Closed

Can't update position in animation editor #15646

thankjura opened this issue Jan 12, 2018 · 5 comments

Comments

@thankjura
Copy link

Godot version:
3.0.beta.custom_build.702e28f

OS/device including version:
gentoo/gtx1070/nvidia-drivers-390.12

Issue description:
Can't update pose in animationplayer editor

Steps to reproduce:
create animation, move cursor in timeline

Minimal reproduction project:
anim_bug.zip

peek 2018-01-13 02-51

@ghost ghost added this to the 3.0 milestone Jan 13, 2018
@bfloch
Copy link
Contributor

bfloch commented Jan 13, 2018

I can replicate this.

Must be a regression within the last days' commit.
Specifically this falls through now:
https://github.com/godotengine/godot/blob/master/editor/plugins/animation_player_editor_plugin.cpp#L992

@bojidar-bg You think this is related to 9b8e8b2 ?

@capnm
Copy link
Contributor

capnm commented Jan 13, 2018

Yes, commit 9b8e8b2 last altered the editor and broke it …
the c1c17b0 is ok.

@bojidar-bg
Copy link
Contributor

Grr, knew something was wrong with the current_animation...
Will be able to fix it later tonight, but if someone wants to fix it earlier, there are a two main options:

  1. [easiest] AnimationPlayerEditor should set some metadata about the current animation, instead of relying on set/get_current_animation, or
  2. [best] AnimationPlayer should get a new get/set_assigned_animation, which would unconditionally return playback.assigned and would execute those commented lines when set:
    ERR_FAIL_COND(!animation_set.has(p_anim));
    playback.current.pos = 0;
    playback.current.from = &animation_set[p_anim];
    playback.assigned = p_anim;

@thankjura
Copy link
Author

Any news?

@akien-mga akien-mga changed the title Can't update pose in animation editor Can't update position in animation editor Jan 13, 2018
@bojidar-bg
Copy link
Contributor

Yes, starting to work on it now. Seems like Saturday night is not the best time to promise things for..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants