Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom external editors for Mono #15913

Closed
redxdev opened this issue Jan 20, 2018 · 9 comments
Closed

Support custom external editors for Mono #15913

redxdev opened this issue Jan 20, 2018 · 9 comments

Comments

@redxdev
Copy link

redxdev commented Jan 20, 2018

The external editor option for mono currently only supports MonoDevelop and VS Code. I suggest an additional option, where it will let you enter a command to execute to open an editor. This probably would require a "Custom Editor" option in the dropdown, and an additional field to enter the path to the editor.

The custom editor option would probably also need to support some form of formatting string in order to feed the file path (and line number?) to the command.

As an example, if I want to use Visual Studio:

"C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe" /Edit %s

Where %s would be replaced by the filepath.

@neikeq
Copy link
Contributor

neikeq commented Jan 20, 2018

I'm not sure if we should add a Mono-only custom external editor option, since you can use the language-agnostic one.
I plan to add support for opening scripts with Visual Studio via the DTE interface. The command line is very limited.

@redxdev
Copy link
Author

redxdev commented Jan 21, 2018

I completely forgot about the language-agnostic setting. And good to hear that VS support is planned.

That said, maybe it's worth discussing anyway - a separate editor for Mono vs gdscript does make sense (you might not want to open gdscript files in Visual Studio, for example) so if the mono editor setting is staying, I think it still would warrant having a custom editor option.

@mysticfall
Copy link
Contributor

mysticfall commented Jan 21, 2018

I'm already using Rider to develop Godot projects and found it working great.

But I was also a bit confused at first to see that it only lists VS Code and MonoDevelop as viable options before I realized there was another option I could use.

Maybe we may consider changing the labels to prevent users from thinking it was impossible to use other editors.

@Rinma
Copy link

Rinma commented Feb 3, 2018

I use Rider too but I tried VS Code and I like the synchronization between Godot and the external editor. So I think a config field for custom editor settings would be a nice option only when it means that Godot will sync/talk to the custom external editor like it does with VS Code.

@MightyPrinny
Copy link
Contributor

I would like to have a separate external editor option for mono because currently I have to deactivate the external editor whenever I want to do something in gdscript.

@Kowbell
Copy link

Kowbell commented May 18, 2019

Maybe we may consider changing the labels to prevent users from thinking it was impossible to use other editors.

I definitely agree with this. It took me a second to figure out that the "Disabled" option for Editor Settings > Mono > Editor > External Editor actually means "Use language-agnostic editor specified in Text Editor setttings." I'm not sure what would be the better text for this entry... "Default"? "Language-Agnostic"? "Same as GDScript"?

I'm not sure if we should add a Mono-only custom external editor option, since you can use the language-agnostic one.

Conversely, it seems inconsistent that the user can specify a custom external editor path and flags for GDScript/language-agnostic editing but they only have a drop-down list of preset options for Mono.

@AldieNightStar

This comment has been minimized.

@Calinou
Copy link
Member

Calinou commented Apr 28, 2020

@AldieNightStar Please don't bump issues without contributing significant new information. Use the 👍 reaction button on the first post instead.

@raulsntos
Copy link
Member

@raulsntos raulsntos added this to the 4.1 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants