Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rider as external editor for Godot mono version #34181

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

van800
Copy link
Contributor

@van800 van800 commented Dec 7, 2019

Allows to select Rider as external editor.
On attempt to open file Rider executable would be located and stored to a setting.
Setting can be manually edited to use different Rider installation.
Next time on attempt to open file path from that setting would be used if it still exists.

related to #15913

Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to what I commented, can we move GodotTools.Rider to GodotTools.Ides.Rider?

@neikeq
Copy link
Contributor

neikeq commented Dec 8, 2019

It would be great if Rider made use of the IdeConnection library for debugging and also for quicker file opening (command line seems to have a noticeable delay). I wanted to make a plugin for Rider as it's the IDE I use, but I can't tell when I will have time to (most likely not before June of next year).

@van800
Copy link
Contributor Author

van800 commented Dec 8, 2019

It would be great if Rider made use of the IdeConnection library for debugging and also for quicker file opening (command line seems to have a noticeable delay). I wanted to make a plugin for Rider as it's the IDE I use, but I can't tell when I will have time to (most likely not before June of next year).

Glad to read that. After New Year I would definitely try to add something more (in a separate PRs).
We normally use https://github.com/JetBrains/rd for communication between processes.

@akien-mga
Copy link
Member

Could you squash commits into one? See PR workflow.

@van800
Copy link
Contributor Author

van800 commented Dec 11, 2019

I wonder why for this repo squashing/merging/rebasing is not available directly in the github UI. Normally it should be. However I am on it.

@akien-mga
Copy link
Member

It is available, but we don't use it, as it doesn't fit well in our workflow and requirements for a clean, self-documenting Git history.

@akien-mga akien-mga modified the milestones: 4.0, 3.2 Dec 11, 2019
@akien-mga akien-mga merged commit cd9d513 into godotengine:master Dec 11, 2019
@akien-mga
Copy link
Member

Thanks!

[*]
indent_style = space
indent_size = 2
end_of_line = lf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why default to 2-space indentation? Also, this file doesn't end with a newline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR was already merged, I suggest we just talk on discord
van800#9412.
Would it be ok?

@van800 van800 deleted the rider branch December 11, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants