-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rider as external editor for Godot mono version #34181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to what I commented, can we move GodotTools.Rider
to GodotTools.Ides.Rider
?
It would be great if Rider made use of the |
Glad to read that. After New Year I would definitely try to add something more (in a separate PRs). |
Could you squash commits into one? See PR workflow. |
I wonder why for this repo squashing/merging/rebasing is not available directly in the github UI. Normally it should be. However I am on it. |
It is available, but we don't use it, as it doesn't fit well in our workflow and requirements for a clean, self-documenting Git history. |
Thanks! |
[*] | ||
indent_style = space | ||
indent_size = 2 | ||
end_of_line = lf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why default to 2-space indentation? Also, this file doesn't end with a newline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this PR was already merged, I suggest we just talk on discord
van800#9412.
Would it be ok?
Allows to select Rider as external editor.
On attempt to open file Rider executable would be located and stored to a setting.
Setting can be manually edited to use different Rider installation.
Next time on attempt to open file path from that setting would be used if it still exists.
related to #15913