Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when reimporting a different sound file with same name #30559

Closed
urusuru opened this issue Jul 13, 2019 · 8 comments
Closed

Crash when reimporting a different sound file with same name #30559

urusuru opened this issue Jul 13, 2019 · 8 comments

Comments

@urusuru
Copy link

urusuru commented Jul 13, 2019

Godot version:
3.1.1

OS/device including version:
Windows.

Issue description:
When you import the same sound again (update sound) and you try to play it crashes engine.

Steps to reproduce:
Import sound with a specific name.
Play it in engine.
Reimport, same name, different sound.
Play again.

Minimal reproduction project:

@urusuru urusuru changed the title import sound Sound import again crash. Jul 13, 2019
@SonarShroom
Copy link
Contributor

I'll take it! Hopefully I can have this in less than a month, if all goes right.

@akien-mga akien-mga changed the title Sound import again crash. Crash when reimporting a different sound file with same name Jul 15, 2019
@akien-mga akien-mga added this to the 3.2 milestone Jul 15, 2019
@creikey
Copy link
Contributor

creikey commented Aug 9, 2019

@SonerSound Are you still working on this issue?

@SonarShroom
Copy link
Contributor

@creikey Yes, however I've not pushed anything to my fork unfortunately. Work hasn't helped in the slightest as well.

@Anutrix
Copy link
Contributor

Anutrix commented Nov 17, 2019

I tried it. Godot crashed as soon as I replaced the file(even before I could try to play it).

@volzhs
Copy link
Contributor

volzhs commented Jan 10, 2020

can't reproduce it with a0ce88f
editor does not crash.

@Anutrix
Copy link
Contributor

Anutrix commented Jan 10, 2020

It would be good to know which commit fixed it as I think this could happen to other kinds of assets.

@KoBeWi
Copy link
Member

KoBeWi commented Jan 12, 2020

I can confirm this in 3.2 beta6.

You need to use the built-in audio player (the one in the bottom of the inspector when you double-click audio asset). Play it, change the file and the resource will reimport, but the player will not refresh. Trying to double-click the asset again to refresh the player will freeze the editor.

Seems to happen only with OGG files.

EDIT:
It's actually duplicate of #26964

@akien-mga
Copy link
Member

Duplicate of #26964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants