Vulkan: Enabling SDFGI slows down editor (+ crashes launching scene in Mono build)

[Xartorx]

Godot version:
e5bb89c (Mono build)

OS/device including version:
Windows 10 / Nvidia GeForce GTX 1080 Ti (457.30) / Vulkan

Issue description:
Enabling SDFGI in Enviroment causes slowdown of editor when turning camera around. Also lots of errors.

Errors:

ERROR: The vertex format used to create the pipeline does not match the vertex format bound.
at: (drivers\vulkan\rendering_device_vulkan.cpp:6586)
ERROR: Attempted to use an unused shader variant (shader is null),
at: (.\servers/rendering/renderer_rd/pipeline_cache_rd.h:71)
ERROR: Condition "!pipeline" is true.
at: draw_list_bind_render_pipeline (drivers\vulkan\rendering_device_vulkan.cpp:6379)

Video:

out.mp4

Also, on Mono version launching with SDFGI causes launched scene to crash.

Errors:

ERROR: Storage buffer supplied (binding: 1) is invalid.
at: (drivers\vulkan\rendering_device_vulkan.cpp:5152)
ERROR: Condition "!uniform_set" is true.
at: draw_list_bind_uniform_set (drivers\vulkan\rendering_device_vulkan.cpp:6454)
ERROR: Mono: FATAL ERROR '* Assertion at ..\mono\mini\debugger-agent.c:4175, condition `!tls' not met
(in domain , error)', ABORTING! Logfile: 'C:\Users\George\AppData\Roaming/Godot/mono/mono_logs/2021-02-12_04.16.43_19360.log'.
at: mono_log_callback (modules\mono\mono_gd\gd_mono_log.cpp:92)

Error at opening the project, but it doesn't happen very often.

Steps to reproduce:
Open project and enable SDFGI in Main scene.

Minimal reproduction project:
Test.zip

[kimabjorkede]

I get the same issues on a non-mono build.

[Calinou]

Enabling SDFGI in Enviroment causes slowdown of editor when turning camera around.

This is currently expected since the SDF has to be generated when the camera is moving or rotating. This is especially noticeable when the camera is moving at high speeds. We need to figure out a way to remove this stuttering (e.g. by capping the speed at which the SDF can be regenerated), but it might not be easy.

[kimabjorkede]

Enabling SDFGI in Enviroment causes slowdown of editor when turning camera around.

This is currently expected since the SDF has to be generated when the camera is moving or rotating. This is especially noticeable when the camera is moving at high speeds. We need to figure out a way to remove this stuttering (e.g. by capping the speed at which the SDF can be regenerated), but it might not be easy.

Yes, but it spews out errors which makes the output unreadable.

[Calinou]

Looking at the video, the slowdown actually doesn't seem to be caused by the SDF updating rather by the error spam in the console. Minimizing the console might help a bit in this case, but probably not much.

[kimabjorkede]

Looking at the video, the slowdown actually doesn't seem to be caused by the SDF updating rather by the error spam in the console. Minimizing the console might help a bit in this case, but probably not much.

Yes it does, at least for me.

Browsing the remote node tree is nearly impossible as well.

Curiously the errors don't appear if SDFGI is turned off when starting the game, and later is turned on. They only appear if the game is started with it on.

[Calinou]

@kimabjorkede Can you still reproduce this bug in the latest master branch or nightly builds?

[Calinou]

Closing due to lack of response. Please comment if you can still reproduce this bug. Make sure to upload a minimal reproduction project as well.