Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when importing broken bmp file #46542

Closed
qarmin opened this issue Mar 1, 2021 · 0 comments · Fixed by #46555
Closed

Crash when importing broken bmp file #46542

qarmin opened this issue Mar 1, 2021 · 0 comments · Fixed by #46555

Comments

@qarmin
Copy link
Contributor

qarmin commented Mar 1, 2021

Godot version:
3.2.4.rc.custom_build. 8385a0d

OS/device including version:
Ubuntu 20.04

Issue description:
When trying to open broken bmp file, then Godot crashes with this backtrace:

[1] godots() [0x1736270] (/mnt/Miecz/godot3.2/platform/x11/crash_handler_x11.cpp:54)
[2] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7fd8a708d210] (??:0)
[3] ImageLoaderBMP::convert_to_image(Ref<Image>, unsigned char const*, unsigned char const*, unsigned int, ImageLoaderBMP::bmp_header_s const&) (/mnt/Miecz/godot3.2/modules/bmp/image_loader_bmp.cpp:133)
[4] ImageLoaderBMP::load_image(Ref<Image>, FileAccess*, bool, float) (/mnt/Miecz/godot3.2/modules/bmp/image_loader_bmp.cpp:290)
[5] ImageLoader::load_image(String, Ref<Image>, FileAccess*, bool, float) (/mnt/Miecz/godot3.2/core/io/image_loader.cpp:67 (discriminator 2))
[6] ResourceImporterTexture::import(String const&, String const&, Map<StringName, Variant, Comparator<StringName>, DefaultAllocator> const&, List<String, DefaultAllocator>*, List<String, DefaultAllocator>*, Variant*) (/mnt/Miecz/godot3.2/editor/import/resource_importer_texture.cpp:400 (discriminator 3))
[7] EditorFileSystem::_reimport_file(String const&) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1788)
[8] EditorFileSystem::reimport_files(Vector<String> const&) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1984 (discriminator 3))
[9] EditorFileSystem::_update_scan_actions() (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:592)
[10] EditorFileSystem::_notification(int) (/mnt/Miecz/godot3.2/editor/editor_file_system.cpp:1164)
[11] EditorFileSystem::_notificationv(int, bool) (/mnt/Miecz/godot3.2/editor/editor_file_system.h:110 (discriminator 14))
[12] Object::notification(int, bool) (/mnt/Miecz/godot3.2/core/object.cpp:931)
[13] SceneTree::_notify_group_pause(StringName const&, int) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:992)
[14] SceneTree::idle(float) (/mnt/Miecz/godot3.2/scene/main/scene_tree.cpp:529 (discriminator 3))
[15] Main::iteration() (/mnt/Miecz/godot3.2/main/main.cpp:2115)
[16] OS_X11::run() (/mnt/Miecz/godot3.2/platform/x11/os_x11.cpp:3628)
[17] godots(main+0x326) [0x172cefc] (/mnt/Miecz/godot3.2/platform/x11/godot_x11.cpp:57)
[18] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7fd8a706e0b3] (??:0)
[19] godots(_start+0x2e) [0x172cb1e] (??:?)

Steps to reproduce:

  1. Just open editor

Minimal reproduction project:
ImportFiles.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants