Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex Shader (for CanvasItems) rotates to the wrong direction in Godot 3.2.4. #46895

Closed
koodikulma-fi opened this issue Mar 11, 2021 · 3 comments

Comments

@koodikulma-fi
Copy link

koodikulma-fi commented Mar 11, 2021

Godot version:
Godot 3.2.4 rc1-4. Works correctly in Godot 3.2.3 stable.

OS/device including version:
Windows 10, GLES3. (GPU: Nvidia GTX1080)

Issue description:
When creating a VertexShader (with just VERTEX = VERTEX; in the vertex function), and rotating the CanvasItem (eg. a Sprite), the rotation direction is flipped. See screenshot. (The 'editing boundary' of the Sprite rotates correctly, graphical content not.)

Steps to reproduce:

  • Create a Sprite.
  • Create a ShaderMaterial for it.
  • Create a Shader script.
  • Write into the script:
shader_type canvas_item;
void vertex() {
   VERTEX = VERTEX; // Uncommenting this, makes it work fine - as the shader is essentially bypassed.
}

problem_screenshot

Minimal reproduction project:
VertexShaderProblem.zip

@koodikulma-fi koodikulma-fi changed the title Vertex Shader rotates to the wrong direction (was ok in 3.2.3 stable). Vertex Shader rotates to the wrong direction in Godot 3.2.4. Mar 11, 2021
@koodikulma-fi koodikulma-fi changed the title Vertex Shader rotates to the wrong direction in Godot 3.2.4. Vertex Shader (for CanvasItems) rotates to the wrong direction in Godot 3.2.4. Mar 11, 2021
@Calinou
Copy link
Member

Calinou commented Mar 11, 2021

I can reproduce this on 3.2.4rc3, both with the GLES3 and GLES2 renderers. However, this doesn't occur when batching is disabled in the Project Settings (both in GLES3 and GLES2).

cc @lawnjelly

@lawnjelly
Copy link
Member

Ah this sounds like a simple polarity mishap lol. I'll take a look. 😀

@lawnjelly
Copy link
Member

Fixed by #46898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants