Batching - fix basis polarity in large fvf #46898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slight technical hitch, the basis was reversed that was sent to the shader, so rotations were opposite. This PR reverses polarity of the basis to be correct.
akien-mga
approved these changes
Mar 11, 2021
|
Thanks! |
lawnjelly
added a commit
to lawnjelly/godot
that referenced
this pull request
Apr 3, 2021
An earlier PR godotengine#46898 had flipped the rotation basis polarity. This turns out to also need a corresponding flip for the light angles for the lighting to make sense.
lekoder
pushed a commit
to KoderaSoftwareUnlimited/godot
that referenced
this pull request
Apr 24, 2021
An earlier PR godotengine#46898 had flipped the rotation basis polarity. This turns out to also need a corresponding flip for the light angles for the lighting to make sense.
briansemrau
added a commit
to briansemrau/godot
that referenced
this pull request
May 4, 2021
Changes based on fix in godotengine#46898
akien-mga
pushed a commit
to akien-mga/godot
that referenced
this pull request
May 5, 2021
Changes based on fix in godotengine#46898 (cherry picked from commit 57e3f35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight technical hitch, the basis was reversed that was sent to the shader, so rotations were opposite. This PR reverses polarity of the basis to be correct.
Fixes #46895
Notes