Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godot app does not close files when loading resources from zip container, so it crashes. #48697

Closed
jhusak opened this issue May 13, 2021 · 2 comments · Fixed by #42337
Closed

Godot app does not close files when loading resources from zip container, so it crashes. #48697

jhusak opened this issue May 13, 2021 · 2 comments · Fixed by #42337
Labels
bug topic:core
Milestone
4.0

Comments

@jhusak
Copy link

jhusak commented May 13, 2021 •
edited
Loading

I have not found similar issues.

Godot version:
All versions 3.x

OS/device including version:
Linux, OsX, probably all versions

Issue description:
When running exported game to data.zip container, game runs till all descriptors are busy and opened, then cannot load resources, so it freezes.
Minimal project attached, after several seconds it freezes with error.

Minimal reproduction project:
LoopTest.tar.gz
@akien-mga akien-mga added this to the 4.0 milestone May 13, 2021
@akien-mga
Copy link
Member

akien-mga commented May 13, 2021 •
edited
Loading

That sounds related to the issue described in this PR, which might fix it: #40303.

Edit: And/or this PR: #42337.

@akien-mga
Copy link
Member

I tested and confirmed that #42337 fixes it.

@akien-mga akien-mga mentioned this issue May 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Fix zip file opening twice zaevi/godot
2 participants
@jhusak @akien-mga