Fix zip file opening twice

[zaevi]

Fixes #42329
Fixes #48697

[akien-mga]

I wonder if it's correct to remove this one. godot_open is the one that minizip will call internally, and godot_close is used to close the handle. Maybe it's the other open that we should remove or properly close, before letting minizip do its own logic of open/read/close? I'm not familiar with the internals of minizip though so maybe it's not necessary.

[akien-mga]

See also core/io/zip_io.cpp which uses a similar pattern where the zopen_file function will call FileAccess::open (but there the opaque FileAccess data is not open beforehand).

[zaevi]

See also core/io/zip_io.cpp which uses a similar pattern where the zopen_file function will call FileAccess::open (but there the opaque FileAccess data is not open beforehand).

Oh, this is proper in logic. I will modify for this

[akien-mga]

Note that ZipArchive::try_open_pack likely has the same issue of double open too.

[akien-mga]

I just noticed that there's also this PR which relates to the same code, probably trying to solve a similar issue: #40303. This code is a bit tricky as I don't know any current maintainer who is familiar with this code, so it's hard to assess changes.

[akien-mga]

I'm not familiar with the minizip API and the pros/cons of switching from using the opaque pointers to the stream ones. But the implementation seems good and it fixes an important bug, so unless anyone objects the changes, I'll merge. (Poke @reduz @punto- @RandomShaper)

[RandomShaper]

LGTM.

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.

[akien-mga]

Cherry-picked for 3.3.1.